Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Themes generated from the starter no longer inherit the docs site workflow or the starter's descriptions. Mirrors rtCamp/plugin-elementary#95.
Technical Details
documentation.ymlhad no repository guard, so every generated theme inherited a GitHub Pages build and deploy job. Its build job now runs only inrtCamp/theme-elementary;deployneedsbuild, so it is skipped too. Init removes the file on first setup (STARTER_REPO_FILES), and.gitattributesexport-ignores it socomposer create-projectleaves it out.tests/js/starter-files.test.jskeeps the two lists in step.package.json,composer.jsonandstyle.cssdescriptions use theElementary Themename token, so init renames them. Previously generated themes shipped "A starter theme that facilitates…" and "A modern starter theme…", including in Appearance → Themes.Checklist
.gitattributesexport-ignore path is an init cleanup target on first setup; on re-init or--clean, a project's owndocumentation.ymlis kept.@rtcamp/wp-tooling2.0.0 identity replacements,--name="Demo Site"turns all three descriptions into "Demo Site block theme, built on rtCamp theme-elementary."actionlintpasses ondocumentation.yml.npm run test:js(starter-files test) and the docs build on this PR.Screenshots
N/A
To-do
composer create-projectcommands (README.md,docs/getting-started.md) to the generated theme's own package, which does not exist on Packagist. That is left out of this PR: feat(init): add cleanup.replace and cleanup.unset wp-tooling#68 (cleanup.replace/cleanup.unset) adds what init needs, and the theme fix follows once it is merged.Fixes/Covers issue
N/A
🤖 Generated with Claude Code